Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker's showIcon property is missing in the interface in prime v18 #16412

Closed
rogeru opened this issue Sep 20, 2024 · 1 comment
Closed
Labels
Resolution: Invalid Issue or pull request is not valid in the latest version

Comments

@rogeru
Copy link

rogeru commented Sep 20, 2024

Describe the bug

In prime v18 beta 1, the showIcon property of the datepicker component seems to be still used but missing in the interface
https://github.com/primefaces/primeng/blob/18.0.0-beta.1/src/app/components/datepicker/datepicker.interface.ts

v18 docs also still list the property.

Environment

prime v18 beta 1

Reproducer

No response

Angular version

18.2.5

PrimeNG version

18.0.0-beta.1

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

20.16.0

Browser(s)

Chrome latest

Steps to reproduce the behavior

No response

Expected behavior

No response

@rogeru rogeru added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 20, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-beta.3 milestone Oct 11, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for reporting the issue, it seems that the issue has been fixed in v18.0.0-beta.2

Please see: https://v18.primeng.org/datepicker#api.datepicker.props.showIcon

Closing the issue.

@cetincakiroglu cetincakiroglu removed this from the 18.0.0-beta.3 milestone Oct 16, 2024
@cetincakiroglu cetincakiroglu added Resolution: Invalid Issue or pull request is not valid in the latest version and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Invalid Issue or pull request is not valid in the latest version
Projects
None yet
Development

No branches or pull requests

2 participants