Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PasswordModule UI is different from InputTextModule UI when fields are disabled #16393

Closed
manukudur opened this issue Sep 17, 2024 · 2 comments
Closed

PasswordModule UI is different from InputTextModule UI when fields are disabled #16393

manukudur opened this issue Sep 17, 2024 · 2 comments
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0-beta.3

Comments

@manukudur
Copy link

Describe the bug

i want to disable the input fields while interacting with api. but i feel UI is not similar when input fields are disabled.

input fields without disabled
Screenshot 2024-09-16 154533

input fields with disabled
Screenshot 2024-09-16 154445

my suggestion is both fields should look similar and also 'toggleMask' should not work when disabled.

code link --> stackblitz

Environment

dev

Reproducer

No response

Angular version

18.1.0

PrimeNG version

18.0.0-beta.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.15.1

Browser(s)

No response

Steps to reproduce the behavior

added stackblitz link

Expected behavior

my suggestion is both fields should look similar and also 'toggleMask' should not work when disabled.
@manukudur manukudur added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 17, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-beta.3 milestone Oct 11, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 16, 2024
@cetincakiroglu cetincakiroglu self-assigned this Oct 16, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for testing the beta and reporting the issue!

cetincakiroglu added a commit that referenced this issue Oct 16, 2024
@cetincakiroglu
Fix disabled state, fixes #16393
c66a145
@cetincakiroglu
Copy link
Contributor

Fixed in c66a145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
18.0.0-beta.3
Development

No branches or pull requests
2 participants
@manukudur @cetincakiroglu