Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PrimeNG 18 beta 1 theme interop with Angular Remote MFE - Styles not loaded #16350

Open
JacobSiegle opened this issue Sep 5, 2024 · 1 comment
Labels
Resolution: Needs More Information More information about the issue is needed to find a correct solution
Milestone

Comments

@JacobSiegle
Copy link
Contributor

JacobSiegle commented Sep 5, 2024

Describe the bug

With the new primeng theme it seems like the CSS getting loaded into the app relies on viewing a page on a shell app with the provided component on it. For example I only see these two classes loaded when I view a component in the shell app that has a card in it.
image

The issue is that if you view an MFE app without visiting the needed components in the parent app the styles will never be loaded in -
image

Any ideas on fixing like some method for forcing all styles + tokens to be loaded right away?

Environment

N/A

Reproducer

No response

Angular version

18.2.3

PrimeNG version

18.0.0-beta.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v18.20.4

Browser(s)

No response

Steps to reproduce the behavior

Load shell app
Visit never view a page with a p-card so styles are not loaded in
Load remote MFE app
See primeng components missing styles in remote MFE app

Expected behavior

Styles load as expected

@JacobSiegle JacobSiegle added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 5, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 18.0.0-beta.2 milestone Sep 9, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 9, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

This issue has been fixed with the 18.0.0-beta.2 could you please check and feedback?

@cetincakiroglu cetincakiroglu added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. Resolution: Needs More Information More information about the issue is needed to find a correct solution and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs More Information More information about the issue is needed to find a correct solution
Projects
Status: No status
Development

No branches or pull requests

3 participants