Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyFilter > Regex : still can use forbidden char #16345

Open
Khanaash opened this issue Sep 4, 2024 · 1 comment
Open

KeyFilter > Regex : still can use forbidden char #16345

Khanaash opened this issue Sep 4, 2024 · 1 comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone

Comments

@Khanaash
Copy link

Khanaash commented Sep 4, 2024

Describe the bug

Using your demo on the KeyFilter page documentation, on the field which blocks < > * !, i still can enter them into the field.
image

I reproduced it locally with the custom keyFilter Regex /^[a-zA-Z0-9\-\/,]+$/ where i still can use any caracter in the field.

Environment

Reproduced on the deployed version of https://primeng.org/keyfilter, today.

Reproduced locally, angular 17.3, primeng 17.18.7, Chrome Version 121.0.6167.160, french keyboard

Reproducer

No response

Angular version

17.3.0

PrimeNG version

17.18.7

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.13.0

Browser(s)

Chrome Version 121.0.6167.160

Steps to reproduce the behavior

(Maybre a prerequisite : use keyboard in french mode)

  1. Go to https://primeng.org/keyfilter
  2. Position your cursor in the field "Block < > * !" in the Regex section
  3. Before typing any of the forbidden, type any of the following caracters : ¨ ^ `
  4. Then, when one of these caracters wait for the next caracter, type a forbidden one

image

Expected behavior

The forbidden caracters can be used

@Khanaash Khanaash added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 4, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@mertsincan mertsincan added this to the Future milestone Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
Status: Review
Development

No branches or pull requests

2 participants