Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Overlay Animation Properties for Menu and Calendar Components #16344

Open
rahulkutah opened this issue Sep 4, 2024 · 1 comment
Open
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@rahulkutah
Copy link

Describe the bug

Hi PrimeNG Team,

I would like to request a feature enhancement regarding the overlay animations for the Menu and Calendar components. Currently, there is an inconsistency in how the animations are handled during the hide transition between these two components.

Menu Component:

The enter transition includes both opacity and a transform (scaleY) effect:
transition(':enter', [style({ opacity: 0, transform: 'scaleY(0.8)' }), animate('{{showTransitionParams}}')])

However, during the leave transition, only the opacity is animated, and the transform is omitted:
transition(':leave', [animate('{{hideTransitionParams}}', style({ opacity: 0 }))])

Calendar Component:

Similarly, for the Calendar, the enter transition uses both opacity and transform effects:
transition('void => visible', [style({ opacity: 0, transform: 'scaleY(0.8)' }), animate('{{showTransitionParams}}', style({ opacity: 1, transform: '*' }))])

The leave transition also only animates the opacity, even though the transform is included with a wildcard (*):
transition('visible => void', [animate('{{hideTransitionParams}}', style({ opacity: 0 }))])

Environment

prime ng version: 17.18.9
angular version: 18.1.0

Reproducer

No response

Angular version

18.1.0

PrimeNG version

17.18.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.15.1

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Popup mode for menu component
  2. When calendar component overlay shows or hides

Expected behavior

Both components should include a transform animation in the hide transition, matching the enter transition for a smoother and more consistent animation, like other components which are using Overlay like Dropdown, Multiselect or Autocomplete

@rahulkutah rahulkutah added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 4, 2024
@rahulkutah
Copy link
Author

Any update on this????

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Dec 4, 2024
@mertsincan mertsincan modified the milestones: 17.18.13, 17.x Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: No status
Development

No branches or pull requests

3 participants
@mertsincan @rahulkutah and others