Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: dynamicdialog example import missing, build problem #16328

Closed
qwadrox opened this issue Sep 2, 2024 · 0 comments · Fixed by #16337
Closed

Docs: dynamicdialog example import missing, build problem #16328

qwadrox opened this issue Sep 2, 2024 · 0 comments · Fixed by #16337
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@qwadrox
Copy link
Contributor

qwadrox commented Sep 2, 2024

Describe the bug

The provided example would not build on Stackblitz:
https://primeng.org/dynamicdialog#example

Missing this import: import { DialogService, DynamicDialogRef } from 'primeng/dynamicdialog';

Furthermore, we should consider including the usage of DynamicDialogConfig, and showcase data passing from the calling component to the dialog component. (Arised: https://github.com/orgs/primefaces/discussions/2615)

Environment

Reproducer

No response

Angular version

18

PrimeNG version

17.18.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@qwadrox qwadrox added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 2, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 10, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.10 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants