Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: ColumnFilter is applied on enter but not on click outside #16310

Open
puschie286 opened this issue Aug 29, 2024 · 1 comment
Open

Table: ColumnFilter is applied on enter but not on click outside #16310

puschie286 opened this issue Aug 29, 2024 · 1 comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@puschie286
Copy link

puschie286 commented Aug 29, 2024

Describe the bug

ColumnFilter applies the filter on enter - but not on click outside. In both cases is the filter value saved and visually applied.

This results in an invalid visual state:
grafik
( Pressing ESC results in the same invalid state )

Same behavior for display row and menu.

Environment

Tested on documentation page

Reproducer

https://primeng.org/table#filter

Angular version

17.3.2

PrimeNG version

17.18.7

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.12.2

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Enter value into text filter (display=row)
  2. Click outside of filter
  3. See visually applied filter but no change in table content

Expected behavior

For display row or menu (when showButtons = false or showApplyButton = false ):

  1. Enter value into text filter
  2. Click outside of filter
  3. Filter is applied OR Filter value is discarded
    ( i think applying is more what the user expect )
@puschie286 puschie286 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 29, 2024
@puschie286
Copy link
Author

note: if you delete your filter value (clear the input), its immediately applied (so its behave different than entering)

Suggestions: filter is only applied on focus lost (regardless if you enter or delete the value).
Addition: Option to only apply on Enter and discard filter changes on focus lost

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Dec 4, 2024
@mertsincan mertsincan modified the milestones: 17.18.13, 17.x Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: No status
Development

No branches or pull requests

2 participants