Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Menu - Keyboard navigation does not skip items where visible has been set to false #16300

Open
Eagle-Tim opened this issue Aug 28, 2024 · 1 comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone

Comments

@Eagle-Tim
Copy link

Eagle-Tim commented Aug 28, 2024

Describe the bug

When using the up and down cursor keys to navigate the items of a menu component (a popup menu in this case) any items where the visible property has been set to false are not skipped, and are still selected (nothing in visibly selected, but if the option is a link, then Enter can then be pressed to action the hidden link).

Environment

Windows 10 OS

Reproducer

https://stackblitz.com/edit/roxz1j?file=src%2Fapp%2Fmenu-popup-demo.ts

Angular version

18.1.2

PrimeNG version

17.18.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.14.0

Browser(s)

Edge 128.0.2739.42

Steps to reproduce the behavior

  1. Create a (pop-up) menu with at least one item where visible is set to false
  2. Press enter on the relevant button to show the menu
  3. Press the Down Arrow on the keyboard to navigate through the menu items

Expected behavior

Only visible items are selected. The focus indicator should not disappear.

Notes

A similar issue was fixed back in March for the TieredMenu component - See #15058

@Eagle-Tim Eagle-Tim added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 28, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@mertsincan mertsincan added this to the Future milestone Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
Status: Review
Development

No branches or pull requests

3 participants
@mertsincan @Eagle-Tim and others