Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change config.ripple to signal for better reactivity #16295

Closed
cetincakiroglu opened this issue Aug 26, 2024 · 1 comment
Closed

Change config.ripple to signal for better reactivity #16295

cetincakiroglu opened this issue Aug 26, 2024 · 1 comment
Assignees
@cetincakiroglu
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
18.0.0-beta.1

Comments

@cetincakiroglu
Copy link
Contributor

ripple in PrimeNGConfig will be updated as signal.

New use:

import { PrimeNGConfig } from 'primeng/api';
.....
config: PrimeNGConfig = inject(PrimeNGConfig);

config.ripple.set(true); // set new value

config.ripple(); // get the value
.....
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Breaking Change Issue contains a breaking change related to a specific component Core Team Issue or pull request has been *opened* by a member of Core Team labels Aug 26, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-beta.1 milestone Aug 26, 2024
@cetincakiroglu cetincakiroglu self-assigned this Aug 26, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 26, 2024
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 26, 2024
cetincakiroglu added a commit that referenced this issue Aug 26, 2024
@cetincakiroglu
Change config.ripple to signal for better reactivity fixes #16295
612160e
@cetincakiroglu
Copy link
Contributor Author

Fixed in v18.0.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
18.0.0-beta.1
Development

No branches or pull requests
3 participants
@cetincakiroglu and others