Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steps: aria-expanded is inappropiate and can be misleading #16266

Closed
SoyDiego opened this issue Aug 21, 2024 · 0 comments · Fixed by #16267
Closed

Steps: aria-expanded is inappropiate and can be misleading #16266

SoyDiego opened this issue Aug 21, 2024 · 0 comments · Fixed by #16267
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.11

Comments

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 21, 2024 •
edited
Loading

Describe the bug

After an accessibility audit at my company, they said we have issues with the Steps component.
Their message was:

The use of aria-expanded on the steps is inappropriate and can be misleading, use if at all possible only aria current and dimmed.

Environment

Reproducer

Angular version

18

PrimeNG version

17

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

  • Remove aria-expanded from Steps component
@SoyDiego SoyDiego added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 21, 2024
@SoyDiego SoyDiego mentioned this issue Aug 21, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 26, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.11 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.11
Development

Successfully merging a pull request may close this issue.

fix(Steps): remove aria-expanded for a11y and text correction SoyDiego/primeng
2 participants
@SoyDiego @cetincakiroglu