Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picklist: CTRL+A Does Not Move All Columns When Using Move Icon #16260

Closed
shangxqi opened this issue Aug 20, 2024 · 0 comments · Fixed by #16465
Closed

Picklist: CTRL+A Does Not Move All Columns When Using Move Icon #16260

shangxqi opened this issue Aug 20, 2024 · 0 comments · Fixed by #16465
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@shangxqi
Copy link

Describe the bug

Steps:

  1. Press Ctrl + A to select all source data.
  2. Click the 'Move To Right' icon.
  3. Expected result: All source data should be moved to the right.
    Actual result: Only some source data is moved to the right.

The cause of this issue lies in the following code location:

https://github.com/primefaces/primeng/blame/a7ba4deefd89e26df34140ac6b0983a6a3e14109/src/app/components/picklist/picklist.ts#L930

Preliminary cause analysis:
When an element is removed from this.source, the corresponding elements in this.selectedItemsSource are also removed.
pickList_ctrl_A_1
pickList_ctrl_A_2
pickList_ctrl_A_3

Environment

angular17
primeng16

Reproducer

No response

Angular version

17

PrimeNG version

16

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v16.15.1

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Press Ctrl + A to select all source data.
  2. Click the 'Move To Right' icon.

Expected behavior

Expected result: All source data should be moved to the right.
Actual result: Only some source data is moved to the right.

@shangxqi shangxqi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 20, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 18, 2024
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 9, 2024
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants