Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for version 17.13.0 links to breaking change from 17.3.0 #16244

Open
cj-peach opened this issue Aug 15, 2024 · 0 comments
Open

Changelog for version 17.13.0 links to breaking change from 17.3.0 #16244

cj-peach opened this issue Aug 15, 2024 · 0 comments
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@cj-peach
Copy link

Describe the bug

In the changelogs for version 17.13.0, a link incorrectly points to a bug from 17.3.0

- SplitButton | new input properties [\#14426](https://github.com/primefaces/primeng/issues/15220)

the number 14426 refers to a breaking change from 7.3.0, but the github link is correct 15220 - in the github website the link directs you to the wrong one.

Environment

changelogs page in github: https://github.com/primefaces/primeng/blob/master/CHANGELOG.md#17130-2024-04-09

Reproducer

No response

Angular version

n/a

PrimeNG version

n/a

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

n/a

Browser(s)

chrome

Steps to reproduce the behavior

Go to the changelog in github: https://github.com/primefaces/primeng/blob/master/CHANGELOG.md#17130-2024-04-09

in version 17.13.0, click on the first "breaking change" link marked as 14426, and it brings you to 14426.

go back to the changelog

click on the "Full Changelog" link, and open the "files changed" tab. At this point, you can see that the reference "14426" points to a different place than the related link to bug 15220.

If you open the link to 15220 from this page, it is correct for what's described by the change log, but the link itself in the front-end of github is incorrect.

Expected behavior

version 17.13.0 split button link should open to bug 15220: #15220

@cj-peach cj-peach added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 15, 2024
@mertsincan mertsincan added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Dec 4, 2024
@mertsincan mertsincan moved this to Review in PrimeNG Dec 7, 2024
@mertsincan mertsincan modified the milestones: 17.18.13, 17.x Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Review
Development

No branches or pull requests

3 participants