DynamicDialog: Loop ChangeDetection

[raiworld81]

Describe the bug

Since version 17.18.4, there has been a bug where, upon launching a DynamicDialog via the appropriate service, Angular's change detection enters a loop. I have encountered the same issue in version 17.18.8 as well. I believe the problem lies in the containerStyle getter, where continuously recreating the configurations triggers the change detection loop.

Environment

Reproduced in all browsers.

Reproducer

No response

Angular version

17.3.11

PrimeNG version

17.18.8

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

[EnricoMessall]

Hey @raiworld81 i dont think the change detection is doing loops here because of that change. Instead the dynamic dialog is set to the Default Change Detection and doesn't uses OnPush. Thats why you always might see change detection for it because Default triggers CD automatic. So its overall no bug.

So it might be a better request to overall change dynamicdialog to OnPush Change Detection :)

[raiworld81]

Sure, this definitely has an impact. I hadn’t noticed the ChangeDetectionStrategy that was set. In any case, yes, it would be appropriate to modify it.

[Zodiark1020]

This is still an issue, on version 17.18.10.

[github-actions]

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨