Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-autocomplete, p-dropdown: Hover and select state have different colors #16203

Open
jawad-jd-hs opened this issue Aug 8, 2024 · 2 comments
Open
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@jawad-jd-hs
Copy link

Describe the bug

We observe an issue with the prime-ng dropdown/autocomplete component, we are experiencing two different focus states for both on hover and selected. We expect both to be the same as p-multiselect, which has the same hover and select colors. All screenshots that I have included use the same theme.
p-multiselect:
image

p-autocomplete
Two different colors or focus states for hover and selected
image

p-dropdown
The same issue with the p-dropdown which has two different colors for the focus state on selected and hover
image

Environment

I am just working on a simple project with Angular and prime-ng 17 versions without any other UI library or dependency.

Reproducer

No response

Angular version

17.0.0

PrimeNG version

17.18.7

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

No response

Steps to reproduce the behavior

Anyone can observe this in the Prime-ng official documents: https://primeng.org/dropdown

Expected behavior

We expect that Hover and Select state colors should be the same as we observe in the multi-select component

@jawad-jd-hs jawad-jd-hs added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 8, 2024
@rosenthalj
Copy link
Contributor

I believe that PrimeNG is working correctly for p-dropdown, p-autocomplete, and p-multiSelect.

For the p-dropdown and p-autcomplete, the "Blue" corresponds to what is currently selected.

p-multiSelect uses checkboxes to indicate which values are selected.

All three components have both a mouse hover indicator and a keyboard position indicator.

See video listed below where I first select using the keyboard and then I select using the mouse.

mouseAndKeybooardSelections.mov

@mertsincan
Copy link
Member

Could you please try the latest PrimeNG 18 or 19?

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@mertsincan mertsincan added this to the 17.x milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

No branches or pull requests

3 participants