Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: showTime with dateMin creates inconsistencies #16151

Closed
VMM-FE opened this issue Aug 1, 2024 · 3 comments
Closed

Calendar: showTime with dateMin creates inconsistencies #16151

VMM-FE opened this issue Aug 1, 2024 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@VMM-FE
Copy link

VMM-FE commented Aug 1, 2024

Describe the bug

When using the component of the calendar with the [showTime]="true" [dateMin]="dateMin" creates some inconsistencies with the workflow. Sometimes it works fine:

working fine

First case:
Sometimes it just unable to select the min date (in the gif example min time was 15):

min time not accessible

Second case:
Other times it's an infinite flow of decreasing the time (in the gif example min time was 10):

decreasing time forever

I don't know why this is happening but it should always work as the first gif no matter the time or what the user clicks before accessing the time (I don't even know how to really reproduce it because sometimes works fine, sometimes is the first case and others is the second).

Thanks in advance!

Environment

Reproducer

No response

Angular version

Last version

PrimeNG version

Last version

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

https://stackblitz.com/edit/c7hasn?file=src%2Fapp%2Fcalendar-time-demo.ts,src%2Fapp%2Fcalendar-time-demo.html,package.json

Expected behavior

If the dateMin says that the min time it's 15:00 that should be the min time to select. And shouldn't be an inconsistence of going from 15 to 16 when clicking the down arrow.

@VMM-FE VMM-FE added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 1, 2024
@VMM-FE
Copy link
Author

VMM-FE commented Aug 1, 2024

Maybe it's related with this other issue #15609

@ThoSap
Copy link
Contributor

ThoSap commented Sep 11, 2024

Another inconsistency with minDate can also be found here #15391

@cetincakiroglu cetincakiroglu modified the milestones: 17.18.11, 17.18.12 Sep 26, 2024
@mehmetcetin01140 mehmetcetin01140 modified the milestones: 17.18.12, 17.18.13 Nov 13, 2024
@mertsincan mertsincan modified the milestones: 17.18.13, 17.x Dec 9, 2024
@mertsincan mertsincan removed this from the 17.x milestone Dec 25, 2024
@mertsincan mertsincan removed this from PrimeNG Dec 25, 2024
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation and try the latest PrimeNG version(v19). If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

5 participants