Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-dropdown keyboard navigation #16105

Closed
vikore opened this issue Jul 26, 2024 · 5 comments
Closed

p-dropdown keyboard navigation #16105

vikore opened this issue Jul 26, 2024 · 5 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@vikore
Copy link

vikore commented Jul 26, 2024

Describe the bug

Keyboard navigation issue -
Drop down value is not getting selected while navigating the item list through keyboard up/down arrow keys in the latest release version - 17 - https://primeng.org/dropdown#accessibility. It was working in previous release version - 15 - https://www.primefaces.org/primeng-v15-lts/dropdown#accessibility.

Environment

Development

Reproducer

No response

Angular version

17.3.6

PrimeNG version

17.16.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Navigate to p-dropdown using keyboard tab key
  2. Press space key or enter key to open dropdown
  3. Then press up/down arrow keys
  4. Observe the drop down value. It is not getting selected with arrow key navigation. User has to press enter key to select the highlighted value.

Expected behavior

Drop down value should get selected while navigating with up/down arrow keys as in previous version - 15 along with enter key and spacebar key.

@vikore vikore added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 26, 2024
@vikore vikore changed the title p-dropdown p-dropdown keyboard navigation Aug 5, 2024
@vikore
Copy link
Author

vikore commented Aug 5, 2024

Hi Team,

Please let us know if any updates regarding the issue.

Also keyboard tab key event is adding additional focus to the item list of the drop down. In previous version it was navigating to next action element.

p-dropdown

Thanks

@richard-collette-precisely
Copy link

richard-collette-precisely commented Sep 10, 2024

It is apparent on the docmentation screen
https://www.primefaces.org/primeng-v14-lts/dropdown

That tabbing between inputs is broken.

Additionally, when tabbing into a drop down, if the dropdown is editable, keyboard input is not enabled until the field is clicked on.

Related to #13957

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation and try the latest PrimeNG version(v19). If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

@richard-collette-precisely

This is an AWFUL way to manage a backlog. Closing out issues with no related commit. No validation of the issue. You're basically dismissing the input of your paying customers.

@mertsincan
Copy link
Member

We had about 1k–2k open issues, and many users have told us that most are already fixed in newer versions. Most reports come from different users, not the original reporters.
If you think the issue still exists, you can create a new issue using our new issue template and select supported versions in it. You can also help by sending a PR to fix the issue. PrimeNG is an open-source project, and it grows with contributions from the community. We appreciate your support!

Version data;
92 issues FIXED for v18
42 issues FIXED for v19(includes all 18.0.1 fixes)
35 issues FIXED for v19.0.2

New issue roadmap; https://github.com/orgs/primefaces/projects/4

LTS version support;
https://primeng.org/lts

STS means open source short term support whereas LTS stands for commercial long term support. Legacy versions are only supported by PrimeNG PRO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants