Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion: Case-sensitive tag name causes CSS issues #16090

Closed
gregorwinkler opened this issue Jul 24, 2024 · 1 comment
Closed

Accordion: Case-sensitive tag name causes CSS issues #16090

gregorwinkler opened this issue Jul 24, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@gregorwinkler
Copy link

Describe the bug

To use the accordion and its tabs, we have to use p-accordionTab in our code.
When the app is then built, the tag name changes to p-accordiontab.

This is generally not a problem, as element tags are case-insensitive in CSS.

However, we have the problem that we purge our CSS to reduce the file size. As the base-theme refers to p-accordiontab and thus our overwrites as well, while in the template files there is only p-accordionTab, all styles are purged, as PurgeCSS is case-sensitive.

If there is no problem about it, I think it makes most sense to just have the same spelling for the accordion tab element tag and not to have a different one in the build version.

Environment

All

Reproducer

No response

Angular version

17.1.3

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v21.7.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@gregorwinkler gregorwinkler added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 24, 2024
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants