Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeNG Not Building with latest Master - missing search-insights #16031

Closed
awdorrin opened this issue Jul 15, 2024 · 3 comments
Closed

PrimeNG Not Building with latest Master - missing search-insights #16031

awdorrin opened this issue Jul 15, 2024 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@awdorrin
Copy link

Describe the bug

ng build of current pull from git results in:

Application bundle generation failed. [33.787 seconds]

✘ [ERROR] TS2307: Cannot find module 'search-insights' or its corresponding type declarations. [plugin angular-compiler]

    node_modules/@algolia/autocomplete-plugin-algolia-insights/dist/esm/types/InsightsClient.d.ts:1:74:
      1 │ ...hodMap, InsightsClient as _InsightsClient } from 'search-insights';
        ╵                                                     ~~~~~~~~~~~~~~~~~


✘ [ERROR] TS2307: Cannot find module 'search-insights' or its corresponding type declarations. [plugin angular-compiler]

    node_modules/@algolia/autocomplete-plugin-algolia-insights/dist/esm/types/InsightsClient.d.ts:2:211:
      2 │ ...TokenChange as InsightsOnUserTokenChange, } from 'search-insights';

Environment

Windows 11 build environment

Reproducer

No response

Angular version

18.0.2

PrimeNG version

17.18.4

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

git clone of master
npm install
ng serve

Expected behavior

No response

@awdorrin awdorrin added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 15, 2024
@awdorrin
Copy link
Author

I found you have to install search-insights manually:
npm install search-insights

@JimmyBarrientos
Copy link

Can confirm that @awdorrin 's solution works. Not sure why it isnt included in the latest.

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation and try the latest PrimeNG version(v19). If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants