Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: buttons missing spaces on mobile #15884

Closed
dalenguyen opened this issue Jun 22, 2024 · 3 comments
Closed

FileUpload: buttons missing spaces on mobile #15884

dalenguyen opened this issue Jun 22, 2024 · 3 comments
Assignees
@cetincakiroglu
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
18.0.0-beta.1

Comments

@dalenguyen
Copy link
Contributor

Describe the bug

There is no spaces for buttons on mobile.

image

Environment

Production

Reproducer

https://primeng.org/fileupload#advanced

Angular version

18.0.0

PrimeNG version

17.8.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.0.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/fileupload#advanced
  2. View it on mobile

Expected behavior

There're should be spaces for buttons on mobile
@dalenguyen dalenguyen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 22, 2024
@snehithssv
Copy link

So a simple adding margin should do the work??
image
@dalenguyen, is this the desired output??

@snehithssv snehithssv mentioned this issue Jul 4, 2024
Closed
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Jul 4, 2024 •
edited
Loading

Hi,

Thanks for reporting the issue but we don't add margins manually to the component.css file. All of them are generated from primeng-sass-theme repo depending on the variables of themes. Also, we're implementing a new theming engine and all the styling will be revised, probably this issue will be solved during this process.

Also instead of adding a margin, you can use header template and do whatever you want.

@cetincakiroglu cetincakiroglu added Resolution: Wontfix Issue will not be fixed due to technical limitations and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 4, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Jul 4, 2024
@cetincakiroglu cetincakiroglu removed the Resolution: Wontfix Issue will not be fixed due to technical limitations label Jul 4, 2024
@cetincakiroglu cetincakiroglu reopened this Jul 4, 2024
@cetincakiroglu cetincakiroglu self-assigned this Jul 4, 2024
@cetincakiroglu cetincakiroglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jul 4, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 4, 2024
@cetincakiroglu
Copy link
Contributor

Fixed in v18.0.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
18.0.0-beta.1
Development

No branches or pull requests
3 participants
@dalenguyen @cetincakiroglu @snehithssv