-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component: Button -> pButton #15862
Comments
I think this is where the problem happened |
<button pButton pRipple #btn
class="p-button-info w-full" icon="pi pi-file-import"
[loading]="loadingImport"
(click)="import(btn)"
></button> |
Please, share a stackblitz. Thanks! |
I couldn't really reproduce this in Stackblitz. I tried to reduce this there before I opened the Issue. I have only had this since the update to 17.18.1. At 17.18.0 it works without any problems. See the pictures. And if I only change the version of PrimeNG, it can only be due to PrimeNG. And I just went through the PRs and saw that the loading icons were changed. I use Lara as a design. If you need more input to solve the problem, I will be happy to help. |
I have created a reproducer for this issue: The reproducer shows PrimeNG "loading" buttons. The first two buttons are the exact problem described in this Issue #15862. The 5th and 6 buttons show an additional issue with "loading". The 3rd, 4th, 7th, and 8th work properly? The following video is running the reproducer: buttonLoadingBug.mov |
I created an improved reproducer for this Issue #15862. The new reproducer is arranged better and adds 2 additional cases. Improved reproducer: https://stackblitz.com/edit/tlmdgz-ctp3t6 The following video is running the new improved reproducer: buttonLoadingProblem.mov |
Fixed in #15893 |
Describe the bug
Hi, I noticed when I went from 17.18.0 to 17.18.1 that the pButton Loading is displayed incorrectly. If Loading is set to true, it displays correctly, but if it goes back to false, the button is no longer disabled, but the loading icon is still there. See image:
Loading:
17.18.0:
After Loading:
17.18.1:
After Loading:
Environment
Reproducer
No response
Angular version
17.3.8
PrimeNG version
17.18.1
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
18.17.1
Browser(s)
Firefox 127.0
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: