Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: p-multiSelectItem - breaking regression #15784

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@pete-mcwilliams
Copy link
Contributor

Describe the bug

after changes introduced in 17.15.0 template handling, using template checkicon causes an error to be raised on selecting an item in the popup:

vendor.js:41996 ERROR TypeError: templateRef.createEmbeddedViewImpl is not a function
    at ViewContainerRef.createEmbeddedView (vendor.js:52142:33)
    at NgTemplateOutlet.ngOnChanges (vendor.js:28787:40)
    at NgTemplateOutlet.rememberChangeHistoryAndInvokeOnChangesHook (vendor.js:39553:10)
    at callHookInternal (vendor.js:40582:10)
    at callHook (vendor.js:40609:5)
    at callHooks (vendor.js:40566:9)
    at executeInitAndCheckHooks (vendor.js:40521:5)
    at selectIndexInternal (vendor.js:46448:9)
    at Module.ɵɵadvance (vendor.js:46432:3)
    at MultiSelectItem_ng_container_3_span_2_Template (vendor.js:170190:60)

try swapping to itemcheckboxicon error goes but template is ignored.

Environment

reproducible in stackblitz

    "primeng": "17.18.0",
    "@angular-devkit/build-angular": "^18.0.2",
    "@angular/animations": "^18.0.1",
    "@angular/cdk": "^18.0.1",
    "@angular/cli": "^18.0.2",
    "@angular/common": "^18.0.1",
    "@angular/compiler": "^18.0.1",
    "@angular/compiler-cli": "^18.0.1",
    "@angular/core": "^18.0.1",
    "@angular/forms": "^18.0.1",
    "@angular/platform-browser": "^18.0.1",
    "@angular/platform-browser-dynamic": "^18.0.1",
    "@angular/platform-server": "^18.0.1",
    "@angular/router": "^18.0.1",
    "chart.js": "4.4.2",
    "primeflex": "^3.3.1",
    "primeicons": "^7.0.0",
    "quill": "2.0.2",
    "rxjs": "~7.8.1",
    "tslib": "^2.5.0",
    "zone.js": "~0.14.0"

Reproducer

https://stackblitz.com/edit/asbm6h?file=src%2Fapp%2Fmulti-select-basic-demo.html

Angular version

18.0.1

PrimeNG version

17.18.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v20.14.0

Browser(s)

No response

Steps to reproduce the behavior

use template for checkicon see that error is raised in console when a checkbox is ticked
use template for itemcheckboxicon see there is no error and the template is ignored.

Expected behavior

No errors templates work, should be able to continue to use checkicon as it is in depreciation and not removed.

@pete-mcwilliams pete-mcwilliams added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 4, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 13, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.1 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
3 participants