Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pTemplate not working for p-menu alone #15781

Closed
alaindeurveilher opened this issue Jun 3, 2024 · 0 comments · Fixed by #15812 · 4 remaining pull requests
Closed

pTemplate not working for p-menu alone #15781

alaindeurveilher opened this issue Jun 3, 2024 · 0 comments · Fixed by #15812 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.1

Comments

@alaindeurveilher
Copy link

Describe the bug

This is a copy of #15608 (Toolbar) but for the p-menu, where we have the same issue. Following the documentation to create a menu by using template does not work.
I found out through the other identical bug fixed for the p-toolbar, that the import of SharedModule is necessary.

Either the documentation should be update or an identical fix for p-menu should be done (and potentially everywhere where pTemplate is possible)

Environment

Angular 17.3.10
PrimeNG 17.18.0

Reproducer

No response

Angular version

17.3.10

PrimeNG version

17.18.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.0

Browser(s)

No response

Steps to reproduce the behavior

Follow the documentation of primeng 17.18.0 to create a p-menu with template, and check wether the template is applied

Expected behavior

pTemplate should be wroking for p-menu
@alaindeurveilher alaindeurveilher added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 3, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 7, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jun 7, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.1 milestone Jun 7, 2024
mehmetcetin01140 added a commit that referenced this issue Jun 7, 2024
@mehmetcetin01140
Fixed #15781 - p-menu | pTemplate not working for p-menu alone
c315ea9
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jun 7, 2024
Merged
cetincakiroglu added a commit that referenced this issue Jun 13, 2024
@cetincakiroglu
Merge pull request #15812 from primefaces/issue-15781
47fa80b 
Fixed #15781 - p-menu | pTemplate not working for p-menu alone
@mehmetcetin01140 mehmetcetin01140 added LTS-PORTABLE Issue's fix will be ported to supported LTS versions LTS-FIXED-16.9.11 labels Jun 14, 2024
This was referenced Jul 18, 2024
Open
Open
@diaz-rigo diaz-rigo mentioned this issue Jul 21, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Jul 26, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.1
2 participants
@alaindeurveilher @mehmetcetin01140