Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table (+ Calendar): p-table requires p-calendar module even if it isn't used #15737

Closed
chasepo opened this issue May 29, 2024 · 1 comment
Closed
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@chasepo
Copy link

chasepo commented May 29, 2024

Describe the bug

Building a prod distribution of an angular app that includes a p-table with a p-columnFilterFormElement results in a build where primeng-calendar.mjs is included in the final output. It looks like this might be that p-columnFilterFormElement includes p-calendar regardless of whether it is being used or not.

Environment

macOS

Reproducer

https://stackblitz.com/edit/github-1rw5mk

Angular version

17.3.7

PrimeNG version

17.16.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

Chrome 125

Steps to reproduce the behavior

  1. npm install -g source-map-explorer
  2. ng build --configuration production
  3. source-map-explorer dist/main.js
  4. review output
  5. verify that primeng-calendar.mjs is listed (in my case 75kb/8%)

Expected behavior

As p-calendar is neither used nor explicitly imported, i did not expect it to be included in my final dist output.

@chasepo chasepo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 29, 2024
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants