Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect: The class "p-highlight" is not applied to selected items #15726

Closed
PacoMPerez opened this issue May 28, 2024 · 3 comments
Closed
Labels
Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior

Comments

@PacoMPerez
Copy link

PacoMPerez commented May 28, 2024

Describe the bug

After updating to version 17.16.0 the class "p-highlight" attached to <li> p-multiselect-item is not present on multiselect component after selection options, it also happening on prime ng 17.17.0 as in the documentation site still not present the "p-highlight" class on selected elements:

No class present:
Captura desde 2024-05-28 17-19-13

I have also checked that the property data-p-highlight changes properly but the class is not applied.

But in Dropdown and Listbox components the class still applying properly after the update:
Captura desde 2024-05-28 17-20-42

Environment

Running on local using Chrome.

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.16.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

Chrome

Steps to reproduce the behavior

  • Use any type of multiselect.
  • Click on an option.
  • Check how the "p-highlight" class is not added how it was done in previous versions.

Expected behavior

  • Add again the "p-highlight" class to the <li> p-multiselect-item.
@PacoMPerez PacoMPerez added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 28, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

We've removed the p-highlight class from all elements with checkbox selection across all Prime UI Libraries. It's not a bug, it was a design decision.

Closing the issue, thanks for reporting!

@cetincakiroglu cetincakiroglu added Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 30, 2024
@laurz94
Copy link

laurz94 commented May 30, 2024

So, what is the plan to support keyboard usage? In a dropdown, arrowing between options or typing the value you want does not show which item is selected. Therefore, the user has no idea which item will be selected when they tab out of the control. It looks as though nothing is selected, but then a value appears in the control. This is bad UX.

@PacoMPerez
Copy link
Author

In my case, to don't break styles that I had applied under that class now I use the attribute as a selector on my styles.

Captura desde 2024-05-30 17-40-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants