Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog : Close directly if called inside callback methods #15725

Closed
quentin-ineat-ca opened this issue May 28, 2024 · 2 comments
Closed
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@quentin-ineat-ca
Copy link

Describe the bug

Hello,

If confirmDialog is already opened and called again to be open inside reject or accept method, the next confirmDialog is automatically closed. But with a little timeout between closing and opening again, it's working.

Environment

Angular app

Reproducer

https://stackblitz.com/edit/g7tnmw?file=src%2Fapp%2Fconfirm-dialog-basic-demo.ts

Angular version

17.3.8

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

Chrome 125

Steps to reproduce the behavior

1- In stackblitz example, click save
2a- If click Yes => Next confirmDialog is automatically closed
2b- if click No => With the timeout, the next confirmDialog works fine.

Expected behavior

ConfirmDialog should show and stay on screen if the method to open is called inside accept or reject methods.

@quentin-ineat-ca quentin-ineat-ca added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 28, 2024
@raiworld81
Copy link

+1

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants