Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Component: scrollHeight 'flex' breaks functionality #15719

Closed
novarider opened this issue May 28, 2024 · 3 comments
Closed

Tree Component: scrollHeight 'flex' breaks functionality #15719

novarider opened this issue May 28, 2024 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@novarider
Copy link

Describe the bug

Reopening #9545 because it's still reproducable. If a tree component with scrollHeight set to 'flex', has an initial empty value and gets a non empty value assigned, tree data is not shown nor the empty placeholder is shown.

Environment

In our app the tree is empty on pageload and then gets data assigned to it, sadly data are not shown if scrollHeight is set to flex.

Reproducer

https://stackblitz.com/edit/stackblitz-starters-zwuvcl

Angular version

17.2.0

PrimeNG version

17.16.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.2.3

Browser(s)

No response

Steps to reproduce the behavior

  • Open stackblitz
  • Click 'Fill tree' button to see the tree breaking.

If scrollHeight is changed to e.g. '200px' component is working fine again.

Expected behavior

scrollHeight should only change height of the tree not key functionality.

@novarider novarider added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 28, 2024
@novarider novarider changed the title Tree Component: Title Tree Component: scrollHeight 'flex' breaks functionality May 28, 2024
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

@novarider
Copy link
Author

Hi, no problem at least an answer at all :)

We stand right before an angular update, I will check if this bug exists with the new version as well and create a new ticket if needed 👍

@mertsincan
Copy link
Member

Thanks a lot for your update! We are in a new process regarding issues. #17069

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants