Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbindDocumentKeydownListener is no longer in DynamicDialogComponent #15702

Closed
urielzen opened this issue May 27, 2024 · 1 comment
Closed

unbindDocumentKeydownListener is no longer in DynamicDialogComponent #15702

urielzen opened this issue May 27, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@urielzen
Copy link

Describe the bug

unbindDocumentKeydownListener method is no longer a method in DynamicDialogComponent in the latest version 17.17.0.

I am in a large code base but I am new to this project, so I am not familiar with the business logic in this particular app. The original dev that wrote this code base is no longer around, so I am not sure why he used unbindDocumentKeydownListener.

I have done some testing removing it, and I cannot find any bugs so far or unexpected results.

Does any one have any background about what this method may be used? and/or why it is no longer included in the lates primeng version?

Environment

Windows 64

Reproducer

No response

Angular version

17

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@urielzen urielzen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 27, 2024
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants