You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I get that this is intentional, but instead of updating the actual date object I want to propose to use something a copy of the object. Not sure why this wasn't done before, as now you update data that you probably don't want to update. I might open a pull request myself if I find the time as this is 2 lines of codes to change.
Environment
Not relevant as it's hardcoded to set the time to 00:00.
But I noticed this error in a table using column filter.
Reproducer
No response
Angular version
^17.3.0
PrimeNG version
^17.17.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
v18.17.0
Browser(s)
No response
Steps to reproduce the behavior
Filter a date with "Date is after".
See the time being changed on all rows.
Expected behavior
The time should not be changed on the original object.
The text was updated successfully, but these errors were encountered:
cetincakiroglu
added
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
LTS-PORTABLE
Issue's fix will be ported to supported LTS versions
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
May 30, 2024
mertsincan
added
Resolution: Help Wanted
Issue or pull request requires extra help and feedback
and removed
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
LTS-PORTABLE
Issue's fix will be ported to supported LTS versions
labels
Dec 25, 2024
Describe the bug
If you use filter date is after the date object's hours is set to 00:00. You can see the line of code doing this here:
primeng/src/app/components/api/filterservice.ts
Line 253 in 3d5b78e
I get that this is intentional, but instead of updating the actual date object I want to propose to use something a copy of the object. Not sure why this wasn't done before, as now you update data that you probably don't want to update. I might open a pull request myself if I find the time as this is 2 lines of codes to change.
Environment
Not relevant as it's hardcoded to set the time to 00:00.
But I noticed this error in a table using column filter.
Reproducer
No response
Angular version
^17.3.0
PrimeNG version
^17.17.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
v18.17.0
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
The time should not be changed on the original object.
The text was updated successfully, but these errors were encountered: