-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P-Splitter: Does not respect minSizes array after upgrading to 17.16.1 #15637
Closed
Labels
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
Milestone
Comments
JCarusWTW
added
the
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
label
May 21, 2024
I can confirm this bug. It also does not work in primeng components demo page. |
+1 |
@cetincakiroglu Probably a duplicate of issue #15629. Looks like a low hanging fruit, which should be easy to fix. Would be nice if it would get fixed with next version (: |
mehmetcetin01140
added
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
Jun 6, 2024
cetincakiroglu
added a commit
that referenced
this issue
Jun 13, 2024
Fixed #15637 - P-Splitter: Does not respect minSizes array after upgr…
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
Describe the bug
We have a p-splitter in our code, with a minSizes array of [25,25] being passed in. We have recently upgraded the primeng version from 16.9.1 to 17.16.1 and the minSizes array is no longer being respected i.e. whereas you used to be unable to drag the p-splitter handle past the minimum of 25% size for either panel, the user is now allowed full resizing between 0 and 100% of the possible size despite the 25% minimums still being in the code. You can reproduce the issue purely by switching between versions (no code changes).
Environment
Windows, typescript, version 17.16.1 for primeng
Reproducer
https://github-7cfjki.stackblitz.io
Angular version
17.3.8
PrimeNG version
17.16.1
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
20.11.0 and/or 21.6.1
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
I expect the behaviour from v17 to match that of v16 (and the docs) i.e. if minSizes is set to 25,25 then the user should be unable to resize either panel to smaller than 25%.
The text was updated successfully, but these errors were encountered: