Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method updateInputfield() doesn't work for 'string' dataType and minDate/maxDate prop provided #15621

Closed
AndrzejKieler opened this issue May 20, 2024 · 1 comment
Closed

Method updateInputfield() doesn't work for 'string' dataType and minDate/maxDate prop provided #15621

AndrzejKieler opened this issue May 20, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@AndrzejKieler
Copy link

AndrzejKieler commented May 20, 2024 •
edited
Loading

primeng/src/app/components/calendar/calendar.ts

Line 1610 in c42b73b

const isDateValid = this.isValidDateForTimeConstraints(date);

In quoted line we pass date object of type 'any', whereas 'isValidDateForTimeConstraints' method takes 'Date' type. I think the method should work also for 'string' dataType to validate timeConstraints correctly.
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 20, 2024
@AndrzejKieler
Copy link
Author

My fault. Didn't note parsing method call in writeValue function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrzejKieler