Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline #15466

Closed
alexciesielski opened this issue May 6, 2024 · 2 comments
Closed

CI pipeline #15466

alexciesielski opened this issue May 6, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@alexciesielski
Copy link
Contributor

alexciesielski commented May 6, 2024

Describe the bug

Seems like unit tests are not being run as part of pull requests, as in a PR of mine I noticed fdescribe and after removing it a lot of tests are failing. In the pr-checker.yml the unit test run has been disabled over 8 months ago.

I would also suggest adding an eslint CI run which we could fail whenever fdescribe or fit is encountered in a unit test.

I would be willing to implement this if given the green light.

@alexciesielski alexciesielski added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 6, 2024
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented May 30, 2024

Hi,

You can contribute by fixing the broken unit tests, it would help a lot 👍
Please create issues for the tests you'll fix. Also, you can extend the coverage if you wish.

We appreciate the support!

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants