You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems like unit tests are not being run as part of pull requests, as in a PR of mine I noticed fdescribe and after removing it a lot of tests are failing. In the pr-checker.yml the unit test run has been disabled over 8 months ago.
I would also suggest adding an eslint CI run which we could fail whenever fdescribe or fit is encountered in a unit test.
I would be willing to implement this if given the green light.
The text was updated successfully, but these errors were encountered:
You can contribute by fixing the broken unit tests, it would help a lot 👍
Please create issues for the tests you'll fix. Also, you can extend the coverage if you wish.
So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?
Thanks a lot for your understanding!
Best Regards,
Describe the bug
Seems like unit tests are not being run as part of pull requests, as in a PR of mine I noticed
fdescribe
and after removing it a lot of tests are failing. In thepr-checker.yml
the unit test run has been disabled over 8 months ago.I would also suggest adding an eslint CI run which we could fail whenever
fdescribe
orfit
is encountered in a unit test.I would be willing to implement this if given the green light.
The text was updated successfully, but these errors were encountered: