Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataView [rowsPerPageOption] not working #15455

Closed
PolyakDonat opened this issue May 5, 2024 · 2 comments · Fixed by #15476 · May be fixed by Rodolphe33/gestion-personnel#2 or diaz-rigo/austins#4
Closed

DataView [rowsPerPageOption] not working #15455

PolyakDonat opened this issue May 5, 2024 · 2 comments · Fixed by #15476 · May be fixed by Rodolphe33/gestion-personnel#2 or diaz-rigo/austins#4
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.16.1

Comments

@PolyakDonat
Copy link

Describe the bug

When I add the [rowsPerPageOption] to the p-dataview attribute list it is not loading the dropwdown.

Environment

My environment is a simple local applicationthat is using the p-dataview componenet as the listing mechanism

Reproducer

https://stackblitz.com/edit/github-lnvphz?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.component.html

Angular version

17.3.7

PrimeNG version

17.16.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.15.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Change the rowsPerPageOptions to be equal: [5]
  2. A small empty dropdown will appear
  3. Change it to be e.g.: [5, 15, 30]
  4. There will be no rendered dropdown

Expected behavior

A full list of the options should be rendered in a dropdown.
@PolyakDonat PolyakDonat added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 5, 2024
@RogueTea RogueTea mentioned this issue May 7, 2024
Merged
@PolyakDonat
Copy link
Author

Hey there! Can you give me a rough estimate when this will be merged?

@cetincakiroglu cetincakiroglu added this to the 17.16.1 milestone May 8, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE Issue's fix will be ported to supported LTS versions and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 8, 2024
cetincakiroglu added a commit that referenced this issue May 8, 2024
@cetincakiroglu
Merge pull request #15476 from RogueTea/dataView-rowPerPageOption
6427be7 
Fixed #15455 - DataView [rowsPerPageOption] not working
@Rodolphe33 Rodolphe33 mentioned this issue Jun 11, 2024
Open
@diaz-rigo diaz-rigo mentioned this issue Jun 20, 2024
Open
@axitpoojara
Copy link

is this working with angular 18 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.16.1
3 participants
@PolyakDonat @cetincakiroglu @axitpoojara