Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog: closeOnEscape and dismissableMask not working in combination with closable=false #15401

Closed
dorthrithil opened this issue Apr 29, 2024 · 1 comment · Fixed by #15437
Closed

DynamicDialog: closeOnEscape and dismissableMask not working in combination with closable=false #15401

dorthrithil opened this issue Apr 29, 2024 · 1 comment · Fixed by #15437
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.16.0

Comments

@dorthrithil
Copy link
Contributor

Describe the bug

The closeOnEscape and dismissableMask have no effect when used in combination with closable=false. This kind of makes sense. However the closable description reads "Adds a close icon to the header to hide the dialog." So it's only about the icon.

In my case I didn't want to have the icon but still wanted the dialog to be closable.

Environment

Angular app.

Reproducer

https://stackblitz.com/edit/github-nus4rk-h6lv8i?file=src%2Fapp%2Fapp.component.ts

Angular version

17.1.3

PrimeNG version

17.15.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

21.7.1

Browser(s)

No response

Steps to reproduce the behavior

See reproducer

Expected behavior

The icon can be hidden and the dialog can still be closed.
@dorthrithil dorthrithil added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 29, 2024
@RogueTea RogueTea mentioned this issue May 2, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.16.0 milestone May 3, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE Issue's fix will be ported to supported LTS versions and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 3, 2024
@cetincakiroglu
Copy link
Contributor

Good catch, thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.16.0
2 participants
@dorthrithil @cetincakiroglu