Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global variant set to filled doesn't work #15365

Closed
Shusty-6th opened this issue Apr 25, 2024 · 1 comment
Closed

Global variant set to filled doesn't work #15365

Shusty-6th opened this issue Apr 25, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Shusty-6th
Copy link

Shusty-6th commented Apr 25, 2024

Describe the bug

Setting the global variant to filled does not change the appearance of the displayed controls in the material design theme. Global ripple setting works fine.

  constructor(private primengConfig: PrimeNGConfig) {
    this.primengConfig.ripple = true;
    this.primengConfig.inputStyle = 'filled';
  }

Environment

Just see check stablitz demo. Notice it's md-light-indigo theme.

.

Reproducer

https://stackblitz.com/edit/github-aeyd2t-olhu1d?file=src%2Fapp%2Fapp.component.ts

Angular version

17.3.5

PrimeNG version

17.14.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.0.9

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

I just want to see the filled controls as they appear on the primeNg documentation page when set to filled:
image

@Shusty-6th Shusty-6th added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 25, 2024
@Shusty-6th Shusty-6th changed the title Component: Title Global variant set to filled doesn't work Apr 26, 2024
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants