Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabMenu: activeItemChange duplicate invocation #15329

Closed
parked-toes opened this issue Apr 22, 2024 · 9 comments
Closed

TabMenu: activeItemChange duplicate invocation #15329

parked-toes opened this issue Apr 22, 2024 · 9 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@parked-toes
Copy link

Describe the bug

Use stackblitz example from documentation and add logging of executions:

onActiveItemChange(event: MenuItem) {
    this.activeItem = event;
    console.log(`Executed ${this.i++} times` );
}

Log:
When application inits:
Executed 1 times

1 time click on a tab:
Executed 2 times
Executed 3 times
Executed 4 times

Src:
https://stackblitz.com/edit/air4fc?file=src%2Fapp%2Fdemo%2Ftab-menu-controlled-demo.ts,package.json

Environment

primeng-tab-menu-controlled-demo

Reproducer

No response

Angular version

17.3.1

PrimeNG version

17.14.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

chrome

Steps to reproduce the behavior

No response

Expected behavior

No initial and duplicate firing

@parked-toes parked-toes added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 22, 2024
@IceBreakerG
Copy link

IceBreakerG commented May 8, 2024

I'm seeing the same issue with the TabMenu component. My version is:

  • Angular 17.2.0
  • primeng 17.15.0

@stevenrlp
Copy link

Same issue still present.

  • Angular 18.1.0
  • primeng 17.18.6

@OmkarJ13
Copy link

I am also facing this issue

@alimdi
Copy link

alimdi commented Sep 10, 2024

Same Issue here :

  • Angular 18.1.0
  • primeng 17.18.5

@alimdi
Copy link

alimdi commented Sep 10, 2024

looks like fixed on 17.18.9

@preetamjakhmola
Copy link

looks like fixed on 17.18.9

No, I am using 17.18.9 but it persists.

@alimdi
Copy link

alimdi commented Sep 10, 2024

True, it stopped and now happening again on 17.18.9. There somehow a reason that I can't figure out.

@preetamjakhmola
Copy link

due to that i used different way to solve it. i tried Click event.

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation and try the latest PrimeNG version(v19). If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

7 participants