Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderList: Unable to insert space into input component #15326

Closed
spahicharis opened this issue Apr 21, 2024 · 1 comment · Fixed by #15809 · 4 remaining pull requests
Closed

OrderList: Unable to insert space into input component #15326

spahicharis opened this issue Apr 21, 2024 · 1 comment · Fixed by #15809 · 4 remaining pull requests
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@spahicharis
Copy link

Describe the bug

While using input element inside p-orderList component one is not able to insert space into it. Here is the screenshot example:

image

image

Environment

Issue is easily reproducible on latest primeng version 17.14.1.

Reproducer

No response

Angular version

17.0.8

PrimeNG version

17.14.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

Prerequisites
Have installed Angular app and setup primeng components
Import p-orderList component

Steps to reproduce

  1. Edit p-orderList template (pTemplate="item")
  2. Put basic input field in pTemplate
  3. Run app using command ng serve
  4. Try to put space into input field

Expected behavior

I should be able to insert space into input.

@spahicharis spahicharis added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 21, 2024
@mjlux
Copy link

mjlux commented May 5, 2024

The default behaviour of a OrderListItem on space is to select/unselect the item.
We faced the same issue and resolved it by adding an (keydown.space)="$event.stopPropagation()" EventListener to the input.
Hope this helps.

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 6, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.1 milestone Jun 6, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jun 7, 2024
cetincakiroglu added a commit that referenced this issue Jun 13, 2024
Fixed #15326 - OrderList: Unable to insert space into input component
@mehmetcetin01140 mehmetcetin01140 added LTS-PORTABLE Issue's fix will be ported to supported LTS versions LTS-16-PORTABLE and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment