Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages: OnClose event #15295

Closed
raiworld81 opened this issue Apr 18, 2024 · 0 comments · Fixed by #15310
Closed

Messages: OnClose event #15295

raiworld81 opened this issue Apr 18, 2024 · 0 comments · Fixed by #15310
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.14.0

Comments

@raiworld81
Copy link

Describe the bug

In the removeMessage method of the messages component, the onClose event is triggered after filtering the messages, sending as the event argument a message different from the one closed. The issue lies in the implementation of the method as shown in the figure.

image

Environment

All environments

Reproducer

No response

Angular version

17.3.4

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@raiworld81 raiworld81 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 18, 2024
volvachev added a commit to volvachev/primeng that referenced this issue Apr 19, 2024
@volvachev
fix(primeng/p-messages): close event emit not valid message
a0bd447 
Fixes primefaces#15295.
@volvachev volvachev mentioned this issue Apr 19, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 19, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 19, 2024
@cetincakiroglu cetincakiroglu added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.14.0
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-messages): close event emit not valid message volvachev/primeng
2 participants
@raiworld81 @cetincakiroglu