Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pDroppable: pDroppableDisabled is only evaluated after view init #15282

Closed
playtinum opened this issue Apr 16, 2024 · 2 comments
Closed

pDroppable: pDroppableDisabled is only evaluated after view init #15282

playtinum opened this issue Apr 16, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@playtinum
Copy link

Describe the bug

The evaluation on if the something can be dropped is only evaluated after view init. This makes it impossible to block dropping for distinct elements and enable it for others to "drag time".

See:

if (!this.pDroppableDisabled) {

Environment

primeng version 17.12

Reproducer

No response

Angular version

17.3.0

PrimeNG version

17.12

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.13.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@playtinum playtinum added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 16, 2024
@playtinum
Copy link
Author

Would a PR that targets this issue be accepted or are the efforts be generally wasted?

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants