Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect: Aria-checked attribute is not allowed #15246

Closed
TaneliTuomola opened this issue Apr 10, 2024 · 0 comments · Fixed by #15247
Closed

MultiSelect: Aria-checked attribute is not allowed #15246

TaneliTuomola opened this issue Apr 10, 2024 · 0 comments · Fixed by #15247
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.14.0

Comments

@TaneliTuomola
Copy link

TaneliTuomola commented Apr 10, 2024 •
edited
Loading

Describe the bug

The aria-checked attribute should be used on elements with role=option. Move aria-checked attribute from "p-checkbox-box" to its parent "p-multiselect-item" with option role.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-checked

Environment

https://primeng.org/multiselect

Reproducer

https://primeng.org/multiselect

Angular version

17.0.0

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/multiselect Open multiselect overlay

Expected behavior

No response
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 10, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Apr 10, 2024
fix primefaces#15246 MultiSelect aria checked
24334fd
@TaneliTuomola TaneliTuomola mentioned this issue Apr 10, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 18, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 18, 2024
cetincakiroglu added a commit that referenced this issue Apr 18, 2024
@cetincakiroglu
Merge pull request #15247 from TaneliTuomola/issue-15246
88925d0 
fix #15246 MultiSelect aria checked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.14.0
Development

Successfully merging a pull request may close this issue.

fix #15246 MultiSelect aria checked TaneliTuomola/primeng
2 participants
@cetincakiroglu @TaneliTuomola