Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeSelect: ARIA hidden element must not be focusable or contain focusable elements #15244

Closed
TaneliTuomola opened this issue Apr 10, 2024 · 0 comments · Fixed by #15245
Closed

TreeSelect: ARIA hidden element must not be focusable or contain focusable elements #15244

TaneliTuomola opened this issue Apr 10, 2024 · 0 comments · Fixed by #15245
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.14.0

Comments

@TaneliTuomola
Copy link

TaneliTuomola commented Apr 10, 2024 •
edited
Loading

Describe the bug

Two empty span element between item wrapper div (p-treeselect-items-wrapper) with attribute aria-hidden="true" contains focusable elements.
firstHiddenFocusableElement and lastHiddenFocusableElement: aria-hidden attribute should be removed.

Same issue with MultiSelect fixed by: #15198

Environment

Chrome

Reproducer

https://primeng.org/multiselect

Angular version

17.0.0

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/multiselect open multiselect overlay, run a11y tools

Expected behavior

No response
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 10, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Apr 10, 2024
fix primefaces#15244 MultiSelect hidden focusable elements
0db52dd
@TaneliTuomola TaneliTuomola mentioned this issue Apr 10, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 18, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 18, 2024
cetincakiroglu added a commit that referenced this issue Apr 18, 2024
@cetincakiroglu
Merge pull request #15245 from TaneliTuomola/issue-15244
74644f8 
fix #15244 TreeSelect hidden focusable elements
@cetincakiroglu cetincakiroglu added LTS-PORTABLE Issue's fix will be ported to supported LTS versions Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.14.0
Development

Successfully merging a pull request may close this issue.

fix #15244 TreeSelect hidden focusable elements TaneliTuomola/primeng
2 participants
@cetincakiroglu @TaneliTuomola