Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabMenu: Change Items with Signals #15221

Closed
mirinio opened this issue Apr 5, 2024 · 0 comments
Closed

TabMenu: Change Items with Signals #15221

mirinio opened this issue Apr 5, 2024 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@mirinio
Copy link

mirinio commented Apr 5, 2024

Describe the bug

Changing the TabMenu Items using signals, doesn't update the inkbar.
example

Also, when using a language service (in my case transloco), the inkbar doesn't change when language changes.
The Inkbar should update when the label changes.

Environment

{
"name": "primeng-tab-menu-controlled-demo",
"description": "PrimeNG TabMenuControlledDemo",
"license": "MIT",
"keywords": [],
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test"
},
"dependencies": {
"primeng": "17.12.0",
"@angular-devkit/build-angular": "^17.3.1",
"@angular/animations": "^17.3.1",
"@angular/cdk": "^17.3.1",
"@angular/cli": "^17.3.1",
"@angular/common": "^17.3.1",
"@angular/compiler": "^17.3.1",
"@angular/compiler-cli": "^17.3.1",
"@angular/core": "^17.3.1",
"@angular/forms": "^17.3.1",
"@angular/platform-browser": "^17.3.1",
"@angular/platform-browser-dynamic": "^17.3.1",
"@angular/platform-server": "^17.3.1",
"@angular/router": "^17.3.1",
"chart.js": "3.3.2",
"primeflex": "^3.3.1",
"primeicons": "^6.0.1",
"quill": "1.3.7",
"rxjs": "~7.8.1",
"tslib": "^2.5.0",
"zone.js": "~0.14.0"
}
}

Reproducer

https://stackblitz.com/edit/8saofq?file=src%2Fapp%2Fdemo%2Ftab-menu-controlled-demo.ts

Angular version

17.3.2

PrimeNG version

17.12

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18

Browser(s)

Chrome

Steps to reproduce the behavior

use signals with tabMenu

Expected behavior

tabMenu updates Inkbar when items in the array or only the label changes.

@mirinio mirinio added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 5, 2024
@mirinio mirinio changed the title TabMenu: Update Inkbar doesn't work when changing items TabMenu: Change Items with Signals Apr 5, 2024
@mirinio mirinio closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant