Component: File Upload Choose button plus icon aria label set to "true" instead of hidden

[brndnhrbrt]

Describe the bug

In the File Upload component's fileupload.ts file there are 3 cases where aria labels are being set to "true". This results in accessibility issues and causes screen readers to label the choose button as having "true" in the name.

This issue was added as part of PR: #13477
These 3 labels are the only instance of [attr.aria-label]="true" being used and I believe [attr.aria-hidden]="true" was intended as it was used in other places throughout the PR.

Environment

Any environment running versions 16.2.0 through 17.12.0. Also viewable on the demo page https://primeng.org/fileupload

Reproducer

https://stackblitz.com/edit/github-piysq7?file=src%2Fapp%2Fapp.component.html

Angular version

17.3.2

PrimeNG version

17.12.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.12.1

Browser(s)

No response

Steps to reproduce the behavior

1. Go to https://primeng.org/fileupload#basic on any browser with developer tools
2. Right click and inspect the choose button using developer tools
3. Observe the plusicon element with aria-label set as "true"

Expected behavior

The plusicon element should have no aria label.

[mehmetcetin01140]

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,