Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type of InputNumberInputEvent.value #15206

Closed
Max0nyshchenko opened this issue Mar 31, 2024 · 0 comments · Fixed by #15207
Closed

Incorrect type of InputNumberInputEvent.value #15206

Max0nyshchenko opened this issue Mar 31, 2024 · 0 comments · Fixed by #15207
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.13.0

Comments

@Max0nyshchenko
Copy link
Contributor

Describe the bug

We had issue #15076 that partially fixed the incorrect type of InputNumberInputEvent.value from "number" to "number | string",
but in #15076 we can see that there can be a null value as well, so we need to change from "number | string" to "number | string | null"

Environment

Any environment

Reproducer

No response

Angular version

17

PrimeNG version

17

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Correct type is expected
@Max0nyshchenko Max0nyshchenko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 31, 2024
@Max0nyshchenko Max0nyshchenko mentioned this issue Mar 31, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Apr 9, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 9, 2024
cetincakiroglu added a commit that referenced this issue Apr 9, 2024
@cetincakiroglu
Merge pull request #15207 from Max0nyshchenko/Fixed-15206-Incorrect-t…
301784e 
…ype-of-InputNumberInputEvent-value

Fix #15206 Incorrect type of InputNumberInputEvent.value
@cetincakiroglu cetincakiroglu added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

Fix #15206 Incorrect type of InputNumberInputEvent.value Max0nyshchenko/primeng
3 participants
@Max0nyshchenko @cetincakiroglu @mehmetcetin01140