Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: multiple and readonly still show button to remove options #15188

Closed
mrschamber opened this issue Mar 28, 2024 · 1 comment · Fixed by #15211
Closed

Autocomplete: multiple and readonly still show button to remove options #15188

mrschamber opened this issue Mar 28, 2024 · 1 comment · Fixed by #15211
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.13.0

Comments

@mrschamber
Copy link

Describe the bug

Similar to #9513, it is again the case that an autocomplete with multiple and readonly enabled still shows buttons to remove one entry and if you click that button the entry is deleted.

Environment

Primeng 17.12.0

Reproducer

https://stackblitz.com/edit/github-hqyfeh?file=src%2Fapp%2Fapp.component.html

Angular version

17.3.1

PrimeNG version

17.12.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Add some values to a p-autocomplete with multiple enabled
  2. set readonly to true
  3. delete one entry

The entry is deleted even though the autocomplete is readonly.

Expected behavior

When multiple and readonly are enabled, there should be a way to block the removal of items from the list without disabling the field.
@mrschamber mrschamber added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 28, 2024
@maruthumj
Copy link
Contributor

@mrschamber I will start work on this.

@maruthumj maruthumj mentioned this issue Apr 1, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 9, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Apr 9, 2024
cetincakiroglu added a commit that referenced this issue Apr 9, 2024
@cetincakiroglu
Merge pull request #15211 from maruthumj/autocomplete-readonly
822108e 
Bug #15188 - Autocomplete: multiple and readonly still show button to remove options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.13.0
3 participants
@maruthumj @mrschamber @cetincakiroglu