Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: v14 demo code wrong binary parameter #15167

Closed
Benlier opened this issue Mar 26, 2024 · 3 comments
Closed

Checkbox: v14 demo code wrong binary parameter #15167

Benlier opened this issue Mar 26, 2024 · 3 comments
Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response

Comments

@Benlier
Copy link

Benlier commented Mar 26, 2024

Describe the bug

On the checkbox documentation of v14, the demo can be used in stackblitz to play around with checkboxes.
image

The code used for a 'Basic checkbox' does not use the 'binary' parameter correctly because it isn't encapsulated in square brackets and not property bound to the p-checkbox component.
image
This causes the value to be interpreted as a string instead of a boolean, and changing the value from "true" to "false" will not have the expected result.

I ask for the parameter to be used correctly to avoid confusion for developers in the future.

Environment

Provided stackblitz project of the primeng checbox demo.
https://stackblitz.com/edit/primeng-checkbox-demo?file=src%2Fapp%2Fapp.component.html

Reproducer

No response

Angular version

11.0.0

PrimeNG version

14.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

n/a

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@Benlier Benlier added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 26, 2024
@AAAAAAAArne
Copy link

Thanks, this helped a lot! I verified it.

@mehmetcetin01140 mehmetcetin01140 added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 15, 2024
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Sep 13, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response
Projects
None yet
Development

No branches or pull requests

3 participants