Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel | Tab key malfunction #15111

Closed
cetincakiroglu opened this issue Mar 20, 2024 · 2 comments
Closed

Carousel | Tab key malfunction #15111

cetincakiroglu opened this issue Mar 20, 2024 · 2 comments

Comments

@cetincakiroglu
Copy link
Contributor

  • Focus to the carousel
  • Press tab to navigate between buttons
  • Carousel will start to navigate the carousel items, buttons cannot steal focus.
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Mar 20, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 20, 2024
@cetincakiroglu cetincakiroglu changed the title Carousel | Tab key doesn't work as expected Carousel | Tab key malfunction Mar 20, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 20, 2024
@Zubair-Ofcl
Copy link

Zubair-Ofcl commented Mar 21, 2024

This is the problem with scroll in view. Once start using Tab key, it will navigate to every next actionable if available, bringing page into view without changing current page. Hence once reached on last page using Tab key, navigation button doesn't work as page is already in view.

Moreover, navigation keys aren't being captured at all. enter, space

@cetincakiroglu
Copy link
Contributor Author

Hi,

In the demo, it fails to steal focus because buttons inside the demo content are focusable by default. Setting tabindex to the buttons will remove them from the tabbing order. Unfortunately we cannot interfere with the tabindex values of projected content inside the component, some users might need to focus inside the content. Simply, adding tabindex to the buttons solves the issue. Please see the example: https://stackblitz.com/edit/er3agn?file=src%2Fapp%2Fdemo%2Fcarousel-basic-demo.html

Closing the issue since we cannot reset tabindex values of the projected content.
Thanks for reporting the issue!

@cetincakiroglu cetincakiroglu removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 9, 2024
@cetincakiroglu cetincakiroglu removed this from the 17.13.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants