Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Panel Menu Accessibility Issue: Interactive Controls Must Not Be Nested #15085

Closed
WTW-Jacob-Evans opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User Resolution: Needs More Information More information about the issue is needed to find a correct solution Status: Discussion Issue or pull request needs to be discussed by Core Team

Comments

@WTW-Jacob-Evans
Copy link

Describe the bug

Using Axe DevTools as part of accessibility work, the PanelMenu component raises an issue relating to nested controls.

Is it possible for this to be fixed?

image

image

Environment

Chrome,
Windows 10

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.10.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@WTW-Jacob-Evans WTW-Jacob-Evans added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 19, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 19, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Status: Discussion Issue or pull request needs to be discussed by Core Team Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Mar 19, 2024
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 25, 2024
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Mar 26, 2024

Hi,

We've tried to replicate with Axe Devtools, however mentioned error didn't show up. Apart from unrelated issues from the page, we couldn't catch the mentioned issue. Could you please provide a stackblitz reproducer so we can identify the issue?
Please ignore issues apart from panelMenu component
Screenshot 2024-03-26 at 15 31 44

@cetincakiroglu cetincakiroglu added the Resolution: Needs More Information More information about the issue is needed to find a correct solution label Mar 26, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.13.0, 17.14.0 Apr 9, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.14.0, 17.15.0, 17.Future Apr 19, 2024
@WTW-Jacob-Evans
Copy link
Author

Hi, sorry for the late reply; whilst I am unable to replicate it, I can see the element raising the issue is here
image
Which is the button inside the panelMenu component. Do you have any suggestions why it is raising it as an issue here but not elsewhere?

@WTW-Steve-Martin
Copy link

WTW-Steve-Martin commented Jun 20, 2024

Hi,
Please can I have an update on this bug please.
I checked 17.18.1 and this still seems to be an issue.

@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 16, 2024
@mehmetcetin01140 mehmetcetin01140 removed this from the 19.x milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User Resolution: Needs More Information More information about the issue is needed to find a correct solution Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Development

No branches or pull requests

4 participants