Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Title - #15082

Closed
todaszy opened this issue Mar 19, 2024 · 1 comment
Closed

Component: Title - #15082

todaszy opened this issue Mar 19, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@todaszy
Copy link

todaszy commented Mar 19, 2024

Describe the bug

Table single mode on expand overwrites provided expandedRowKeys property effectively blocking from inspecting expanded state.

Environment

ng app

Reproducer

No response

Angular version

17

PrimeNG version

17

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

<p-table [expandedRowKeys]="expandedRows" rowExpandMode="single">

toggleRow(rowData, event) {
    ...
    let dataKeyValue = String(ObjectUtils.resolveFieldData(rowData, this.dataKey));
    if (this.expandedRowKeys[dataKeyValue] != null) {
      delete this.expandedRowKeys[dataKeyValue];
      ...
    } else {
      if (this.rowExpandMode === 'single') {
// BUG IS HERE
        this.expandedRowKeys = {};
      }
      this.expandedRowKeys[dataKeyValue] = true;
      ...
    }

Expected behavior

      if (this.rowExpandMode === 'single') {
// DO NOT OVERWRITE
        this.expandedRowKeys = {};
      }
@todaszy todaszy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 19, 2024
@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants