Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-progressbar does not show values in certain themes #15064

Closed
dzmcclure-qcells opened this issue Mar 15, 2024 · 2 comments
Closed

p-progressbar does not show values in certain themes #15064

dzmcclure-qcells opened this issue Mar 15, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@dzmcclure-qcells
Copy link

Describe the bug

In some of the prime themes, p-progressbar is very thin and does not show the value. Possibly same issue as #11146, this is not resolved in 17

primeng p-progressbar screenshot

Environment

I am using Angular 17 with PrimeNG 17.2.0, but the issue is also present on the documentation page of PrimeNG at 17.11.0. The theme in question is Ultima, but this occurs with Fluent and Material as well. Probably others.

Reproducer

No response

Angular version

17.0.7

PrimeNG version

17.2.0, 17.11.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/progressbar
  2. Change the theme to Material or Fluent
  3. Progress bars become thin lines with no values

Expected behavior

Progress bars should be wide enough to display a text value

@dzmcclure-qcells dzmcclure-qcells added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 15, 2024
@psarno
Copy link

psarno commented Mar 17, 2024

This is being caused by two separate rules in the theme CSS (possibly intentional).

The first is that it is being set to height: 2px. If that is intended for these themes, it's obviously too small to show a value on. That is defined on the .p-progressbar class.

Which leads us to the label not showing. That is due to the display setting on .p-progressbar-label. It is set to none !important, which prevents it from being rendered.

You can override these properties if you want and just set the height to height: 1.5rem on p-progressbar and display: block on .p-progressbar-label, and it should look correct.

@dzmcclure-qcells
Copy link
Author

I see, I did not realize it was intentional regarding the theme. Thanks for the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants