Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-tree: Incorrect node passed in onNodeSelect when [filter]="true" #15063

Closed
psarno opened this issue Mar 15, 2024 · 1 comment
Closed

p-tree: Incorrect node passed in onNodeSelect when [filter]="true" #15063

psarno opened this issue Mar 15, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@psarno
Copy link

psarno commented Mar 15, 2024

Describe the bug

If you have a <p-tree> component and set [filter]="true" on it, when you filter the tree the wrong node is passed into the onNodeSelect() function.

Repro:

https://stackblitz.com/edit/github-tayhsx

Type "123" into the filter, and click "123". Note that the displayed node is the parent, not the one that was clicked.

primeng

Environment

Angular 17.2.4
PrimeNG 17.8.0

Reproducer

https://stackblitz.com/edit/github-tayhsx

Angular version

17.2.4

PrimeNG version

17.8.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.11.0

Browser(s)

No response

Steps to reproduce the behavior

  1. https://stackblitz.com/edit/github-tayhsx
  2. Filter for "123"
  3. Click "123"

Expected behavior

Expect: Shows "123"
Result: Shows "Parent Node"

@psarno psarno added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 15, 2024
@mehmetcetin01140
Copy link
Contributor

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants